Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect build mode from metadata on deploy #104

Closed
codespool opened this issue Feb 15, 2023 · 0 comments · Fixed by #193 or #205
Closed

Detect build mode from metadata on deploy #104

codespool opened this issue Feb 15, 2023 · 0 comments · Fixed by #193 or #205
Assignees
@pmikolajczyk41 @prxgr4mm3r
Milestone
Grant proposal ro...

Comments

@codespool
Copy link
Collaborator

Contracts should not be deployed in debug mode, so the deploy script should check the metadata for source.build_info.build_mode and warn if it has debug value
@codespool codespool moved this from 💡 New/Idea to 🏁 Ready to Start in Swanky Suite (legacy - moved to swankyhub) Apr 14, 2023
@codespool codespool self-assigned this Apr 14, 2023
@codespool codespool moved this from 🏁 Ready to Start to 🏗 In progress in Swanky Suite (legacy - moved to swankyhub) May 25, 2023
@codespool codespool moved this from 🏗 In progress to 🏁 Ready to Start in Swanky Suite (legacy - moved to swankyhub) May 29, 2023
@codespool codespool moved this from 🏁 Ready to Start to 💡 New/Idea in Swanky Suite (legacy - moved to swankyhub) Jul 5, 2023
@codespool codespool added this to the Grant proposal roadmap milestone Jul 5, 2023
@codespool codespool moved this from 💡 New/Idea to Proposed by Astar in Swanky Suite (legacy - moved to swankyhub) Jul 5, 2023
@codespool codespool removed their assignment Jul 5, 2023
@vsofiya vsofiya moved this from Proposed by Astar to Accepted in Treasury Proposal Roadmap - ink!DevHub 1.0 Nov 6, 2023
@vsofiya vsofiya moved this from Accepted to Proposed by Astar in Treasury Proposal Roadmap - ink!DevHub 1.0 Nov 6, 2023
@prxgr4mm3r prxgr4mm3r linked a pull request Nov 17, 2023 that will close this issue
Detect build mode from metadata on deploy #193
Merged
@vsofiya vsofiya moved this from Proposed by Astar to 🛠 Ready for review in Treasury Proposal Roadmap - ink!DevHub 1.0 Feb 20, 2024
@pmikolajczyk41 pmikolajczyk41 moved this from 🛠 Ready for review to 👀 In review in Treasury Proposal Roadmap - ink!DevHub 1.0 Feb 22, 2024
@pmikolajczyk41 pmikolajczyk41 moved this from 👀 In review to Accepted in Treasury Proposal Roadmap - ink!DevHub 1.0 Feb 22, 2024
ipapandinas added a commit that referenced this issue Feb 26, 2024
@prxgr4mm3r @ipapandinas
feat: Detect build mode on deploy (#104)
e28c7c6 
Co-authored-by: Igor Papandinas <[email protected]>
@ipapandinas ipapandinas mentioned this issue Feb 26, 2024
Merged
ipapandinas added a commit that referenced this issue Mar 25, 2024
@prxgr4mm3r @ipapandinas
feat: Detect build mode on deploy (#104)
749ceaa 
Co-authored-by: Igor Papandinas <[email protected]>
ipapandinas added a commit that referenced this issue Mar 25, 2024
@ipapandinas
Revert "feat: Detect build mode on deploy (#104)"
09b62a7 
This reverts commit 749ceaa.
@ipapandinas ipapandinas moved this from Accepted to ✅ Done in Treasury Proposal Roadmap - ink!DevHub 1.0 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmikolajczyk41 pmikolajczyk41

@prxgr4mm3r prxgr4mm3r

Labels
None yet
Projects
Treasury Proposal Roadmap - ink!DevHub 1.0
Status: ✅ Done
Milestone
Grant proposal roadmap
3 participants
@codespool @pmikolajczyk41 @prxgr4mm3r