Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.taoensso/timbre dep to avoid compilation warnings #99

Closed
kyptin opened this issue Dec 4, 2020 · 2 comments
Closed

Upgrade com.taoensso/timbre dep to avoid compilation warnings #99

kyptin opened this issue Dec 4, 2020 · 2 comments

Comments

@kyptin
Copy link

kyptin commented Dec 4, 2020

Hey, thanks for the nice library. :-)

You're currently depending on version 4.10.0 of com.taoensso/timbre, which depends on version 2.91.0 of com.taoensso/encore, which prints the following warnings during CLJS compilation:

[Figwheel:WARNING] Compile Warning   target/public/cljs-out/min-e2etest/taoensso/encore.cljs   line:2683  column:16

  Use of undeclared Var goog.structs/Map

  2678    (def ^:private coerce-xhr-params "Returns [<uri> <?data>]"
  2679      (let [url-encode
  2680            (fn url-encode
  2681              ([params]
  2682               (when (seq params)
  2683                 (-> params clj->js gstructs/Map. gquery-data/createFromMap .toString)))
                       ^---
  2684
  2685              ([uri params]
  2686               (let [qstr (url-encode params)
  2687                     uri-with-query (if (str/blank? qstr) uri (str uri "?" qstr))]
  2688                 [uri-with-query nil])))

[Figwheel:WARNING] Compile Warning   target/public/cljs-out/min-e2etest/taoensso/encore.cljs   line:2683  column:16

  Use of undeclared Var goog.structs/Map

  2678    (def ^:private coerce-xhr-params "Returns [<uri> <?data>]"
  2679      (let [url-encode
  2680            (fn url-encode
  2681              ([params]
  2682               (when (seq params)
  2683                 (-> params clj->js gstructs/Map. gquery-data/createFromMap .toString)))
                       ^---
  2684
  2685              ([uri params]
  2686               (let [qstr (url-encode params)
  2687                     uri-with-query (if (str/blank? qstr) uri (str uri "?" qstr))]
  2688                 [uri-with-query nil])))

These warnings are noted in this issue in the encore repo.

The fix for users of kee-frame is simple: upgrade to version 5.1.0 of com.taoensso/timbre. The changelog doesn't seem to have anything that would likely affect kee-frame users. I added this version of timbre to my project and didn't have any issues.

Relatedly, looks like re-frame version 1.1.2 is out, so this change could be included with a new kee-frame version 1.1.2.

@ingesolvoll
Copy link
Owner

Thank you for reporting! Will try to get to it in the coming weeks. PR welcome if you feel up for it.

ingesolvoll added a commit that referenced this issue Jan 13, 2021
@ingesolvoll
Copy link
Owner

Seems to work just fine, releasing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants