Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goog.structs/Map is deprecated in Closure Library #47

Closed
roman01la opened this issue Nov 14, 2019 · 2 comments
Closed

goog.structs/Map is deprecated in Closure Library #47

roman01la opened this issue Nov 14, 2019 · 2 comments

Comments

@roman01la
Copy link
Contributor

roman01la commented Nov 14, 2019

I was testing the project with ClojureScript master before they publish a new release and noticed the following warning:

WARNING: Use of undeclared Var goog.structs/Map at line 2683 target-prod/taoensso/encore.cljs

I assume cljs master has updated Closure Library as well.

Looking at Closure docs it says that Map struct is deprecated in favor of ES6 Map https://google.github.io/closure-library/api/goog.structs.Map.html

@ptaoussanis
Copy link
Member

Hi Roman, thanks for the report! PR to update welcome 👍

ptaoussanis pushed a commit that referenced this issue Nov 17, 2019
WARNING: Use of undeclared Var goog.structs/Map at line 2683 target-prod/taoensso/encore.cljs
I assume cljs master has updated Closure Library as well.

Looking at Closure docs it says that Map struct is deprecated in favor of ES6 Map
https://google.github.io/closure-library/api/goog.structs.Map.html
@ptaoussanis
Copy link
Member

Merged, thank you Roman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants