Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created abci test harness #800

Merged

Conversation

greg-szabo
Copy link
Member

Test harness for testing external ABCI applications.

  1. Added cargo build-abci to main workspace (builds kvstore-rs application)
  2. Added abci-harness docker image
  3. Fixed Makefile.toml under the abci-test crate to use the harness

Run tests by:

cd tools/abci-test
cargo make build-linux-abci
cargo make

(If you are on Linux, you can replace the cargo build build-linux-abci command with your own build step.)

Todo: write the GitHub Action.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (thane/abci-integration-test@c8bee2b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             thane/abci-integration-test    #800   +/-   ##
=============================================================
  Coverage                               ?   54.4%           
=============================================================
  Files                                  ?     208           
  Lines                                  ?   14822           
  Branches                               ?    3888           
=============================================================
  Hits                                   ?    8073           
  Misses                                 ?    6410           
  Partials                               ?     339           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bee2b...0fd98e4. Read the comment docs.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thanks @greg-szabo! 🎉

@thanethomson thanethomson merged commit a042caf into thane/abci-integration-test Feb 2, 2021
@thanethomson thanethomson deleted the greg/thane-abci-integration-test branch February 2, 2021 19:39
thanethomson added a commit that referenced this pull request Feb 9, 2021
* Add integration testing utility for ABCI key/value store

Signed-off-by: Thane Thomson <[email protected]>

* Add hacky bash script to demonstrate parallel execution

Signed-off-by: Thane Thomson <[email protected]>

* Created abci test harness (#800)

* Created abci test harness

* cargo make additions and docs

Co-authored-by: Greg Szabo <[email protected]>
brapse pushed a commit that referenced this pull request Feb 19, 2021
* Add minimal blocking ABCI library

Signed-off-by: Thane Thomson <[email protected]>

* Expand API to implement in-memory key/value store app

Signed-off-by: Thane Thomson <[email protected]>

* Add kvstore-rs ABCI app

Signed-off-by: Thane Thomson <[email protected]>

* Add rudimentary README

Signed-off-by: Thane Thomson <[email protected]>

* Bump proto version dependency to v0.18.0

Signed-off-by: Thane Thomson <[email protected]>

* Replace manual default structs with Default::default()

Signed-off-by: Thane Thomson <[email protected]>

* Enable debug logging for all incoming ABCI requests

Signed-off-by: Thane Thomson <[email protected]>

* Improve CLI UX

Signed-off-by: Thane Thomson <[email protected]>

* Allow for read buffer size customization

Signed-off-by: Thane Thomson <[email protected]>

* Add crate description

Signed-off-by: Thane Thomson <[email protected]>

* Update README for ABCI crate

Signed-off-by: Thane Thomson <[email protected]>

* Add ABCI integration test for minimal ABCI crate (#797)

* Add integration testing utility for ABCI key/value store

Signed-off-by: Thane Thomson <[email protected]>

* Add hacky bash script to demonstrate parallel execution

Signed-off-by: Thane Thomson <[email protected]>

* Created abci test harness (#800)

* Created abci test harness

* cargo make additions and docs

Co-authored-by: Greg Szabo <[email protected]>

* Update abci/src/codec.rs

Co-authored-by: Romain Ruetschi <[email protected]>

* Apply suggestion from https://github.com/informalsystems/tendermint-rs/pull/794\#discussion_r573100911

Signed-off-by: Thane Thomson <[email protected]>

* Refactor error handing and expose eyre::Result as crate default Result type

Signed-off-by: Thane Thomson <[email protected]>

* Refactor to use tracing instead of log

Signed-off-by: Thane Thomson <[email protected]>

* Add newline

Signed-off-by: Thane Thomson <[email protected]>

* Remove comment relating to constraints on Codec struct params

Signed-off-by: Thane Thomson <[email protected]>

* Version tendermint-abci crate in line with other tendermint-rs crates

Signed-off-by: Thane Thomson <[email protected]>

* Update CHANGELOG

Signed-off-by: Thane Thomson <[email protected]>

* Expand crate documentation

Signed-off-by: Thane Thomson <[email protected]>

* Extract request dispatch functionality from Application trait

Signed-off-by: Thane Thomson <[email protected]>

* Move ABCI server example to crate root

Signed-off-by: Thane Thomson <[email protected]>

* Fix broken link in docs

Signed-off-by: Thane Thomson <[email protected]>

* Replace EchoApp example with KeyValueStoreApp example

Signed-off-by: Thane Thomson <[email protected]>

Co-authored-by: Greg Szabo <[email protected]>
Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants