Add ABCI integration test for minimal ABCI crate #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
* Created abci test harness * cargo make additions and docs
thanethomson
commented
Feb 2, 2021
| @@ -1,6 +1,7 @@ | |||
| [workspace] | |||
|
|
|||
| members = [ | |||
| "abci-test", | |||
There was a problem hiding this comment.
Thinking about this now, in a follow-up PR, I'd like to replace the abci-test crate with the same kvstore-test that we use for testing Tendermint RPC compatibility. It'll take some more extensive testing, however, and this test does the job for now.
greg-szabo
approved these changes
Feb 8, 2021
brapse
pushed a commit
that referenced
this pull request
Feb 19, 2021
* Add minimal blocking ABCI library Signed-off-by: Thane Thomson <[email protected]> * Expand API to implement in-memory key/value store app Signed-off-by: Thane Thomson <[email protected]> * Add kvstore-rs ABCI app Signed-off-by: Thane Thomson <[email protected]> * Add rudimentary README Signed-off-by: Thane Thomson <[email protected]> * Bump proto version dependency to v0.18.0 Signed-off-by: Thane Thomson <[email protected]> * Replace manual default structs with Default::default() Signed-off-by: Thane Thomson <[email protected]> * Enable debug logging for all incoming ABCI requests Signed-off-by: Thane Thomson <[email protected]> * Improve CLI UX Signed-off-by: Thane Thomson <[email protected]> * Allow for read buffer size customization Signed-off-by: Thane Thomson <[email protected]> * Add crate description Signed-off-by: Thane Thomson <[email protected]> * Update README for ABCI crate Signed-off-by: Thane Thomson <[email protected]> * Add ABCI integration test for minimal ABCI crate (#797) * Add integration testing utility for ABCI key/value store Signed-off-by: Thane Thomson <[email protected]> * Add hacky bash script to demonstrate parallel execution Signed-off-by: Thane Thomson <[email protected]> * Created abci test harness (#800) * Created abci test harness * cargo make additions and docs Co-authored-by: Greg Szabo <[email protected]> * Update abci/src/codec.rs Co-authored-by: Romain Ruetschi <[email protected]> * Apply suggestion from https://github.com/informalsystems/tendermint-rs/pull/794\#discussion_r573100911 Signed-off-by: Thane Thomson <[email protected]> * Refactor error handing and expose eyre::Result as crate default Result type Signed-off-by: Thane Thomson <[email protected]> * Refactor to use tracing instead of log Signed-off-by: Thane Thomson <[email protected]> * Add newline Signed-off-by: Thane Thomson <[email protected]> * Remove comment relating to constraints on Codec struct params Signed-off-by: Thane Thomson <[email protected]> * Version tendermint-abci crate in line with other tendermint-rs crates Signed-off-by: Thane Thomson <[email protected]> * Update CHANGELOG Signed-off-by: Thane Thomson <[email protected]> * Expand crate documentation Signed-off-by: Thane Thomson <[email protected]> * Extract request dispatch functionality from Application trait Signed-off-by: Thane Thomson <[email protected]> * Move ABCI server example to crate root Signed-off-by: Thane Thomson <[email protected]> * Fix broken link in docs Signed-off-by: Thane Thomson <[email protected]> * Replace EchoApp example with KeyValueStoreApp example Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Greg Szabo <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #794 by adding a small Rust-based tool to execute a bunch of transactions against a running Tendermint node, where the Tendermint node's connected to the
kvstore-rsABCI app.