Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvstore test with cargo-make invoking docker #748

Merged
merged 7 commits into from
Dec 18, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Dec 16, 2020

The next step in #723.

  • Introduces the tools folder. Currently only the new kvstore-test crate is in it, but we will add the docker folder, proto-compiler and rpc-probe crates too in time.
  • The new kvstore-test crate uses cargo-make to make the integration tests from the tendermint crate and the tendermint-light-client crate first class citizens.

To execute the tests locally, enter the kvstore-test folder and run cargo test if you have a kvstore endpoint already running, or cargo make if you have the docker CLI installed but no endpoint running.

Benefits:

  • Much smaller codebase

  • The docker image shuts down automatically after a successful test run. (It still keeps running if tests fail, though.)

  • Referenced an issue explaining the need for the change

  • Updated all relevant documentation in docs

  • Updated all code comments where relevant

  • Wrote tests

  • Updated CHANGELOG.md

@codecov-io
Copy link

Codecov Report

Merging #748 (e825a88) into master (27b3b73) will increase coverage by 0.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #748     +/-   ##
========================================
+ Coverage    42.1%   43.1%   +0.9%     
========================================
  Files         206     204      -2     
  Lines       13945   13620    -325     
  Branches     3571    3571             
========================================
- Hits         5876    5874      -2     
+ Misses       7695    7369    -326     
- Partials      374     377      +3     
Impacted Files Coverage Δ
rpc/src/error.rs 44.4% <0.0%> (ø)
rpc/src/event.rs 11.1% <0.0%> (ø)
rpc/src/client.rs 9.3% <0.0%> (+2.1%) ⬆️
rpc/src/endpoint/abci_query.rs 28.5% <0.0%> (+6.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b3b73...e825a88. Read the comment docs.

@greg-szabo greg-szabo marked this pull request as ready for review December 18, 2020 06:35
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I tested this out locally and it works great, thanks Greg! 👍

@greg-szabo greg-szabo merged commit 8bbb09b into master Dec 18, 2020
@greg-szabo greg-szabo deleted the greg/kvstore-test-with-cargo-make branch December 18, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants