kvstore test with cargo-make invoking docker #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step in #723.
tools
folder. Currently only the newkvstore-test
crate is in it, but we will add thedocker
folder,proto-compiler
andrpc-probe
crates too in time.kvstore-test
crate usescargo-make
to make the integration tests from thetendermint
crate and thetendermint-light-client
crate first class citizens.To execute the tests locally, enter the
kvstore-test
folder and runcargo test
if you have a kvstore endpoint already running, orcargo make
if you have the docker CLI installed but no endpoint running.Benefits:
Much smaller codebase
The docker image shuts down automatically after a successful test run. (It still keeps running if tests fail, though.)
Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Updated CHANGELOG.md