kvstore test with built-in docker invoke #747
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please compare to #748
This is example code how we could expand our testing framework with Rust-native test prerequisites built into
build.rs
.Prerequisite:
Benefits:
cargo test
if the endpoint is already runningcargo test --features docker
if the endpoint has to be set upDisadvantages:
The shiplift library used to manage docker is out-of-date and had to be pointed to master.
The docker image cannot be shut down automatically at the end of the test run.
docker stop kvstore-test
has to be run or Tendermint will keep running in the background.Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Updated CHANGELOG.md