Refactoring: rename serializers #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `cargo clippy --all --all-targets -- -Dwarnings -Drust-2018-idioms`
liamsi
commented
May 8, 2020
| assert_eq!(result.unsigned, 9007199254740992); | ||
| assert_eq!(result.signed, -9007199254740994); | ||
| assert_eq!(result.unsigned, 9_007_199_254_740_992); | ||
| assert_eq!(result.signed, -9_007_199_254_740_994); |
There was a problem hiding this comment.
For some reason clippy doesn't run as strictly as it used to be on CI. There a few places where it complained when run with:
cargo clippy --all --all-targets -- -Dwarnings -Drust-2018-idioms
greg-szabo
approved these changes
May 8, 2020
liamsi
added a commit
that referenced
this pull request
May 9, 2020
* Simplified primitives serializers, moved duration, hex and base64 serializers into module * Updated CHANGES.md * Fixed serializers documentation * Update CHANGES.md * Update CHANGES.md * Refactoring: rename serializers (#264) * rename/flatten serializer methods (primitives and time_duration) * Fix all clippy warnings: - `cargo clippy --all --all-targets -- -Dwarnings -Drust-2018-idioms` Co-authored-by: Ismail Khoffi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #255 (comment)