Serialization refactor step 1

[greg-szabo]

• Refactor the serializer library. Move all functions into modules and rewrite the annotation to use with. (Looks nicer.)

This is a first step in refactoring serialization outloined in issue #247 .

• Referenced an issue explaining the need for the change
• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGES.md

Soft-depends on Issue #249 / PR #256 for integration test success.

[liamsi]

I haven't reviewed yet, so if you like, you can rebase this on master (and force push) or merge in master.

[liamsi]

Note that currently all modules under tendermint/src which contain submodules follow the current pattern:

module::submodule in
tendermint/src/module/submodule.rs
submodule is then included in module tree via:
tendermint/src/module.rs
which is then included in module tree via:
tendermint/src/lib.rs

Should we use this pattern here too? Currently all submodules are defined in
tendermint/src/serializers.rs

[greg-szabo]

Step 3 does that but unfortunately the original work had dependencies which would've made this into the "big PR" again, if I implemented it here.

[liamsi]

Thanks for splitting this up @greg-szabo 👍

I left a few minor comments. The PR looks good so far.

[codecov-io]

Codecov Report

Merging #255 into master will decrease coverage by 0.0%.
The diff coverage is 25.0%.

@@           Coverage Diff            @@
##           master    #255     +/-   ##
========================================
- Coverage    27.6%   27.6%   -0.1%     
========================================
  Files          99      99             
  Lines        3651    3650      -1     
  Branches     1169    1168      -1     
========================================
- Hits         1010    1009      -1     
  Misses       1831    1831             
  Partials      810     810             

Impacted Files	Coverage Δ
tendermint/src/abci/proof.rs	50.0% <ø> (ø)
tendermint/src/block.rs	0.0% <ø> (ø)
tendermint/src/block/commit.rs	54.5% <ø> (ø)
tendermint/src/block/header.rs	22.7% <ø> (ø)
tendermint/src/block/parts.rs	0.0% <ø> (ø)
tendermint/src/block/size.rs	0.0% <ø> (ø)
tendermint/src/channel.rs	0.0% <ø> (ø)
tendermint/src/consensus/state.rs	50.0% <ø> (ø)
tendermint/src/evidence.rs	33.3% <0.0%> (ø)
tendermint/src/lite/types.rs	35.4% <ø> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb9661...89b13ae. Read the comment docs.

[liamsi]

Thanks a lot @greg-szabo 👍