-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to make hermes work with non-gaiad custom chains (e.g. starport) #753
Conversation
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=========================================
+ Coverage 13.6% 43.8% +30.1%
=========================================
Files 69 159 +90
Lines 3752 10427 +6675
Branches 1374 0 -1374
=========================================
+ Hits 513 4572 +4059
- Misses 2618 5855 +3237
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks Andy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have one question but it does not block from merging.
@@ -181,7 +183,7 @@ impl CosmosSdkChain { | |||
// Gas Fee | |||
let coin = Coin { | |||
denom: "stake".to_string(), | |||
amount: "1000".to_string(), | |||
amount: "10000".to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to stay hardcoded forever or do we eventually want to make this configurable/dynamic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes:
Description
This PR implements fixes to allow hermes relay packets between two non-gaiad based chains.
These changes were tested against two
starport v0.15.0
(supportscosmos-sdk v0.42.1
). These starport chains have custom account prefix addresses (notcosmos
) such aschainb1pnv0elanhs8qcq2sst0jssak8magjpj3ggq45x
This PR also fixes an issue where the account number is not
0
. For example the starport chains have multiple accounts (e.g.validator
andbob
). So usingbob
account key in the relayer would make the transactions fail because that account number is1
in the key store. After the fix, it works now because the account number is dynamically fetched from the chain using grpc (same logic that gets the account sequence to submit transaction).For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.