Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account number hardcoded #752

Closed
5 tasks done
andynog opened this issue Mar 19, 2021 · 3 comments
Closed
5 tasks done

Account number hardcoded #752

andynog opened this issue Mar 19, 2021 · 3 comments
Labels
A: bug Admin: something isn't working I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Milestone
03.2021

Comments

@andynog
Copy link
Contributor

andynog commented Mar 19, 2021

Crate

ibc-relayer

Summary of Bug

Account number is hard-coded to '0' in the logic to sign a transaction

Version

v0.1.1

Steps to Reproduce

When using a key for an account that is not '0' the tx raw transaction will not work. For example testing with a chain where the key was for an account with number '1' the tx failed with unauthorized.

Change the logic to use the account number retrieved from the chain.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@andynog andynog added A: bug Admin: something isn't working I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic labels Mar 19, 2021
@andynog andynog added this to the 03.2021 milestone Mar 19, 2021
andynog added a commit that referenced this issue Mar 19, 2021
@andynog
Fix bug with hard-coded account number in tx sign (#752)
66f3f24
@andynog andynog mentioned this issue Mar 20, 2021
Merged
5 tasks
andynog added a commit that referenced this issue Mar 20, 2021
@andynog
Updating CHANGELOG, adding fixed issues #416 and #752
a25d544
@romac
Copy link
Member

romac commented Mar 24, 2021

@andynog Can you please open a PR for your fix if it's ready?

@andynog
Copy link
Contributor Author

andynog commented Mar 24, 2021

@andynog Can you please open a PR for your fix if it's ready?

Hi @romac this was fixed on PR #753, not sure why the issue was not closed

@romac
Copy link
Member

romac commented Mar 24, 2021

Oh right, will close it then :)

@romac romac closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Projects
None yet
Milestone
03.2021
Development

No branches or pull requests
2 participants
@romac @andynog