Mac Packaging / Notarization #8878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
ivorybilled
changed the title
|
EDIT: .tar.gz package will remain included and the signed/notarized package will be another option that comes with it. |
|
Not sure, but I think it might still be needed for homebrew: https://formulae.brew.sh/formula/telegraf I guess brew can also unpack from the dmg.. |
ssoroka
approved these changes
Mar 5, 2021
ssoroka
pushed a commit
that referenced
this pull request
Mar 10, 2021
* initial commit * Updated config.yml * Update mac-signing.sh * Updated config.yml * Updated config.yml * Keep the .tar.gz artifact along with the signed and notarized DMG * change to test temporarily * for testing * Updated config.yml * Update config.yml * Update config.yml (cherry picked from commit b6f043c)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* initial commit * Updated config.yml * Update mac-signing.sh * Updated config.yml * Updated config.yml * Keep the .tar.gz artifact along with the signed and notarized DMG * change to test temporarily * for testing * Updated config.yml * Update config.yml * Update config.yml (cherry picked from commit b6f043c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will run a script on 'release' deployments that will sign and notarize our Mac OS packages. Notarization requires the .app format and the binary will be distributed within the Resources of the .app, and the .app will be distributed within a DMG image. Note that those who need direct access to the Telegraf binary can still go into the .app 'folder' and retrieve it as normal.
What this PR accomplishes in a practical manner is that users can now double-click/open the Telegraf app directly after downloading it, and mac OS will not block them from opening it. Users can also run the Telegraf.app through the command line, as follows:
open -a Telegraf.appyou can also pass any Telegraf arguments as follows:
open -a Telegraf.app --args (arguments)resolves #8580