Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegraf for macOS should be signed #8580

Closed
patgmac opened this issue Dec 16, 2020 · 5 comments · Fixed by #8878
Closed

Telegraf for macOS should be signed #8580

patgmac opened this issue Dec 16, 2020 · 5 comments · Fixed by #8878
Assignees
Labels
area/packaging feature request Requests for new plugin and for new features to existing plugins platform/darwin

Comments

@patgmac
Copy link

patgmac commented Dec 16, 2020

Feature Request

Proposal:

Apple has a hard requirement in current versions of macOS for binaries to be signed and notarized. This FR is to start signing the telegraf binary with a valid Apple certificate and notarize as needed. Here is some documentation from Apple on this topic: https://developer.apple.com/support/code-signing/.

This would ideally mean someone at a company level obtaining an company developer account from developer.apple.com, which is $300/year. Personal accounts could be used at $99/year but the signing would appear in that persons name.

Current behavior:

When running telegraf on macOS Big Sur, the following error messages appear:

Screen Shot 2020-12-16 at 3 54 12 PM

Screen Shot 2020-12-16 at 3 54 34 PM

Desired behavior:

telegraf should run without error.

Use case:

For continued use of telegraf on the macOS platform, it will need to be signed and notarized.

@patgmac patgmac added the feature request Requests for new plugin and for new features to existing plugins label Dec 16, 2020
@sjwang90
Copy link
Contributor

sjwang90 commented Jan 6, 2021

@darinfisher Can you provide any feedback for this? See if there's any overlap with the discussions you're having with the Windows signature stuff?

@sjwang90 sjwang90 closed this as completed Jan 6, 2021
@sjwang90 sjwang90 reopened this Jan 6, 2021
@sjwang90 sjwang90 assigned sjwang90 and ivorybilled and unassigned sjwang90 Jan 6, 2021
@patgmac
Copy link
Author

patgmac commented Feb 2, 2021

So what are the chances of this happening?

@sjwang90
Copy link
Contributor

sjwang90 commented Feb 2, 2021

@patgmac We actually have just purchased the certs for this and are just starting to work on getting this implemented in the Telegraf build.

@patgmac
Copy link
Author

patgmac commented Feb 2, 2021

@patgmac We actually have just purchased the certs for this and are just starting to work on getting this implemented in the Telegraf build.

Great news. I hope by "purchased the certs" that means a "paid Apple developer account" which is required for singing apps, not like a regular cert purchased elsewhere. And being that this would require building on Apple hardware, would this also help with #4801 ?

@darinfisher
Copy link
Contributor

@patgmac Yes, the certificates are from our Apple developer account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging feature request Requests for new plugin and for new features to existing plugins platform/darwin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants