Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggregator: move time.now into the aggregator #3693

Merged
merged 1 commit into from
Jan 19, 2018
Merged

aggregator: move time.now into the aggregator #3693

merged 1 commit into from
Jan 19, 2018

Conversation

piotr1212
Copy link
Contributor

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@piotr1212
aggregator: move time.now into the aggregator
a0ae5da 
By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.
@piotr1212
Copy link
Contributor Author

obsoletes #3688

@danielnelson danielnelson added this to the 1.5.2 milestone Jan 19, 2018
@danielnelson danielnelson added the fix pr to fix corresponding bug label Jan 19, 2018
@danielnelson danielnelson merged commit 601dc99 into influxdata:master Jan 19, 2018
danielnelson pushed a commit that referenced this pull request Jan 19, 2018
@piotr1212 @danielnelson
Align aggregator period with internal ticker to avoid skipping metrics (
bb3ee1f 
#3693)

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.

(cherry picked from commit 601dc99)
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@piotr1212 @danielnelson
Align aggregator period with internal ticker to avoid skipping metrics (
3ea7c2d 
#3693)

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr1212 @danielnelson