aggregate: Don't skip metrics which are in next aggretationperiod #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggregate would skip metrics which are not in the current aggregation method. This caused a lot skipped metrics which originated from the logparser plugin. Now if the metric is in the next aggregation interval don't skip it but queue it and process it in the next aggregation interval.
|
Do you know what caused the metrics to be too new? I wonder if perhaps we are not setting the |
|
I couldn't find the reason. Endperiod was looking fine.
…On 17 Jan 2018 20:30, "Daniel Nelson" ***@***.***> wrote:
Do you know what caused the metrics to be too new? I wonder if perhaps we
are not setting the periodEnd correctly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3688 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACxrWlmdljoTSnKPcAaOxzey4oY1W_-pks5tLkj3gaJpZM4RhjPW>
.
|
|
I don't want to add metric buffering to the aggregators, but I am interested in knowing why this was happening. Perhaps the log had future timestamps due to clock skew? |
|
Found the issue. This PR makes no sense. now is set here https://github.com/influxdata/telegraf/blob/master/agent/agent.go#L123 by the time the code reaches the if statement in in RunningAggregator.Run() on my system 600ms passed. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running metrics from logparser through an aggregator I noticed some metrics were lost. Found out in some times the metrics timestamp was later than the current aggregation method. This PR queues metrics in the next aggregation method and processes them the next round. I'm not sure if this the correct way to fix this but it works for us.
Required for all PRs: