Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include zil kstats in the metric collections #2623

Closed
wants to merge 1 commit into from
Closed

Include zil kstats in the metric collections #2623

wants to merge 1 commit into from

Conversation

tomtastic
Copy link

@tomtastic tomtastic commented Apr 4, 2017 •
edited
Loading

To satisfy '[Feature request] ZFS ZIL stats #2200', zil stats are now included in the kstat metric collections.

Tested on Linux (Ubuntu 16.10)
Untested on FreeBSD

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

@tomtastic tomtastic mentioned this pull request Apr 4, 2017
Closed
@tomtastic
Copy link
Author

tomtastic commented Apr 4, 2017 •
edited
Loading

Tests failing on unrelated plugin :

2017/04/04 21:09:43 D! Riemann event states disabled, skipping metric value [running]
--- FAIL: TestConnectAndWrite (0.08s)
Error Trace: riemann_test.go:199
Error: Should not be zero, but was 0
FAIL
FAIL github.com/influxdata/telegraf/plugins/outputs/riemann 0.104s

@rickard-von-essen
Copy link
Contributor

I'll do some testing on FreeBSD 11.0

@danielnelson danielnelson added this to the 1.4.0 milestone Apr 18, 2017
@rickard-von-essen
Copy link
Contributor

Hmm, some quick testing and I can't find any zil sysctl? Do you have any refs to kstat.zfs.misc.zil.zil_commit_count etc?

@tomtastic
Copy link
Author

tomtastic commented Apr 19, 2017 •
edited
Loading

@rickard-von-essen The only useful box I could get access to has FreeBSD 10.2-RELEASE-p17.
But it seems there's no ZIL kstats to be found there either :

# sysctl -a |grep kstat.zfs.misc.zil
#

Perhaps BSD simply doesn't expose ZIL stats?

@rickard-von-essen
Copy link
Contributor

rickard-von-essen commented Apr 20, 2017 •
edited
Loading

I can't find any refs to any ZIL stats on FreeBSD (for example https://github.com/mmatuska/zfs-stats).

I think you can update the PR to not include these for FreeBSD and make a note in the README that zil stats are Linux only.

@tomtastic
Copy link
Author

tomtastic commented Apr 24, 2017 •
edited
Loading

PR updated for Linux ZIL stats only, as FreeBSD has none.

@danielnelson danielnelson modified the milestones: 1.4.0, 1.5.0 Aug 14, 2017
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 24, 2017
@danielnelson danielnelson modified the milestones: 1.5.0, 1.6.0 Nov 30, 2017
@danielnelson danielnelson mentioned this pull request Dec 11, 2017
Merged
@danielnelson
Copy link
Contributor

Closed in favor of #3565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tomtastic @rickard-von-essen @danielnelson