Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.gnmi): Add secret store support for username and password #15173

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 16, 2024

Summary

Add secret store support to username and password config options.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15172

@telegraf-tiger telegraf-tiger bot added area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 16, 2024
@powersj powersj self-assigned this Apr 16, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! Just some small suggestions...

plugins/inputs/gnmi/gnmi.go Outdated Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 17, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Apr 17, 2024
@telegraf-tiger
Copy link
Contributor

@DStrand1 DStrand1 removed their assignment Apr 17, 2024
@srebhan srebhan merged commit 96e7b2b into influxdata:master Apr 17, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gNMI plugin] Add Secretstores support for device username and password
3 participants