Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gNMI plugin] Add Secretstores support for device username and password #15172

Closed
mrhorrible78 opened this issue Apr 16, 2024 · 2 comments · Fixed by #15173
Closed

[gNMI plugin] Add Secretstores support for device username and password #15172

mrhorrible78 opened this issue Apr 16, 2024 · 2 comments · Fixed by #15173
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@mrhorrible78
Copy link

Use Case

The credentials used to connect to a device via the gNMI plugin are stored in clear text in the telegraf.conf file. It would be great if the username and password were able to be stored as secrets instead. In my specific use case, I'd like to use docker secrets.

Expected behavior

The gNMI plugin should support secretstores for device usernames and passwords

Actual behavior

Currently, usernames and passwords are stored in clear text within the configuration file.

Additional info

No response

@mrhorrible78 mrhorrible78 added the feature request Requests for new plugin and for new features to existing plugins label Apr 16, 2024
powersj added a commit to powersj/telegraf that referenced this issue Apr 16, 2024
@powersj
Copy link
Contributor

powersj commented Apr 16, 2024

Hi,

I've put up PR #15172 which adds support to secret stores to the username and password config files. In 20-30mins downloadable artifacts will be attached to the PR. Could you please download them and ensure it works?

Thanks!

@powersj powersj added the waiting for response waiting for response from contributor label Apr 16, 2024
@mrhorrible78
Copy link
Author

Hi,

I've put up PR #15172 which adds support to secret stores to the username and password config files. In 20-30mins downloadable artifacts will be attached to the PR. Could you please download them and ensure it works?

Thanks!

I grabbed the telegraf_1.31.0~9f169c21-0_amd64.deb, created a container, and tested the Docker secretstore function and it works for my use case. Thank you for the quick turn around on this feature request!

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants