-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.gnmi): set max gRPC message size #12495
Conversation
Adds an option to let a user set the max gRPC message size. By default, this is set to 4MB and allows a user to receive larger messages if required by the end device. fixes: influxdata#12463
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I really want the size to be config.Size
in order to make it more human-readable.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @powersj!
I downloaded the Alpine Docker image version 1.25.1 and currently getting this error:
Is this because the network device that I'm connecting to doesn't recognize the "max_msg_size" parameter? My gNMI config looks like this:
|
As this is a feature it will go into 1.26 next month, not 1.25.1. You can also grab a nightly docker image and give it a try there as well. |
Adds an option to let a user set the max gRPC message size. By default, this is set to 4MB and allows a user to receive larger messages if required by the end device.
fixes: #12463