Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option to increase max message size in gNMI plugin. #12463

Closed
mohsin106 opened this issue Jan 5, 2023 · 2 comments · Fixed by #12495
Closed

Expose option to increase max message size in gNMI plugin. #12463

mohsin106 opened this issue Jan 5, 2023 · 2 comments · Fixed by #12495
Assignees
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/m 2-4 day effort

Comments

@mohsin106
Copy link

Use Case

I'd like to have the ability to edit the max message size of the data set that gets streamed in using the gNMI plugin.

My input stanza:

[[inputs.gnmi]]
  addresses = ["10.30.2.8:10161"]
  username = "$user"
  password = "$password"
  redial = "10s"
  enable_tls = true
  insecure_skip_verify = true

  [[inputs.gnmi.subscription]]
    name = "test"
    path = "/slots[name=2]"
    subscription_mode = "sample"
    suppress_redundant = false
     sample_interval = "60s"

I would like an option like max_msg_size that I can assign a value so I can receive datasets that currently exceed the current max size.

This is the error that I'm currently seeing:

2023-01-04T20:18:58Z E! [inputs.gnmi] Error in plugin: aborted gNMI subscription: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (8167002 vs. 4194304)

Expected behavior

I would expect the data to stream in and proceed to go out to the specified output plugin.

Actual behavior

Currently seeing the following error when a data set exceeds the max message size:

2023-01-04T20:18:58Z E! [inputs.gnmi] Error in plugin: aborted gNMI subscription: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (8167002 vs. 4194304)
```the 

### Additional info

I'm currently using Telegraf v1.23.4
[InfluxData Community Support Link for this issue](https://community.influxdata.com/t/telegraf-how-to-increase-allowed-message-size/28001)
@mohsin106 mohsin106 added the feature request Requests for new plugin and for new features to existing plugins label Jan 5, 2023
@powersj powersj added help wanted Request for community participation, code, contribution size/m 2-4 day effort labels Jan 9, 2023
@powersj powersj self-assigned this Jan 9, 2023
@powersj
Copy link
Contributor

powersj commented Jan 9, 2023

Thanks for the issue! Next steps: add the option in a draft PR and confirm it works and fixes the issue.

powersj added a commit to powersj/telegraf that referenced this issue Jan 11, 2023
Adds an option to let a user set the max gRPC message size. By default,
this is set to 4MB and allows a user to receive larger messages if
required by the end device.

fixes: influxdata#12463
@powersj
Copy link
Contributor

powersj commented Jan 11, 2023

@mohsin106 I put up #12495 with a new option. That PR should have artifacts attached to it in 20-30mins. Would you be willing to try those artifacts out and ensure that the new setting resolves your issues?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/m 2-4 day effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants