fix: correctly handle MaxSeriesPerDatabaseExceeded (#23091) #23093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcfarlm3
approved these changes
Feb 2, 2022
lesam
reviewed
Feb 2, 2022
| // Maybe we can just change it to be consistent if we change it also in all | ||
| // the places that construct it. | ||
| // (DSB) This was previously *PartialWriteError. Now catch pointer and value types. | ||
| case PartialWriteError: |
There was a problem hiding this comment.
Should we have a test that shows this? I think both of the existing tests were already returning the right error.
There was a problem hiding this comment.
Both previous code and new code return the same error string, but new code actually completes the partial write as much as possible, instead of turning into a complete failure. I will look to see if there's a reasonable way to verify the partial success in actual data written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the correctly returned PartialWriteError
in (*shard).validateSeriesAndFields, allow partial
writes.
closes #23090
(cherry picked from commit 0c3dca8)
closes #23092