Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle MaxSeriesPerDatabaseExceeded PartialWriteError #23090

Closed
davidby-influx opened this issue Feb 2, 2022 · 0 comments · Fixed by #23091
Closed

Correctly handle MaxSeriesPerDatabaseExceeded PartialWriteError #23090

davidby-influx opened this issue Feb 2, 2022 · 0 comments · Fixed by #23091
Assignees
@davidby-influx
Labels
1.x area/error handling kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

Exceeding the configuration parameter MaxSeriesPerDatabase is incorrectly handled in shard.go because the error type is assumed to be a *PartialWriteError when the returned error is not the pointer type. Add additional logging to show the limit, the number of series currently in the database, and the number of new keys to be created which exceeded the limit.
@davidby-influx davidby-influx self-assigned this Feb 2, 2022
davidby-influx added a commit that referenced this issue Feb 2, 2022
@davidby-influx
fix: correctly handle MaxSeriesPerDatabaseExceeded
16adf2c 
Check for the correctly returned PartialWriteError
in (*shard).validateSeriesAndFields, allow partial
writes.

closes #23090
This was referenced Feb 2, 2022
Merged
Closed
davidby-influx added a commit that referenced this issue Feb 2, 2022
@davidby-influx
fix: correctly handle MaxSeriesPerDatabaseExceeded (#23091)
0c3dca8 
Check for the correctly returned PartialWriteError
in (*shard).validateSeriesAndFields, allow partial
writes.

closes #23090
davidby-influx added a commit that referenced this issue Feb 2, 2022
@davidby-influx
fix: correctly handle MaxSeriesPerDatabaseExceeded (#23091)
38c7c00 
Check for the correctly returned PartialWriteError
in (*shard).validateSeriesAndFields, allow partial
writes.

closes #23090

(cherry picked from commit 0c3dca8)
@davidby-influx davidby-influx linked a pull request Feb 2, 2022 that will close this issue
fix: correctly handle MaxSeriesPerDatabaseExceeded #23091
Merged
3 tasks
@davidby-influx davidby-influx mentioned this issue Feb 2, 2022
Merged
3 tasks
davidby-influx added a commit that referenced this issue Feb 2, 2022
@davidby-influx
fix: correctly handle MaxSeriesPerDatabaseExceeded (#23091) (#23093)
85580fa 
Check for the correctly returned PartialWriteError
in (*shard).validateSeriesAndFields, allow partial
writes.

closes #23090

(cherry picked from commit 0c3dca8)

closes #23092
This was referenced Feb 2, 2022
Merged
Closed
davidby-influx added a commit that referenced this issue Feb 2, 2022
@davidby-influx
fix: correctly handle MaxSeriesPerDatabaseExceeded (#23091)
1be62ad 
Check for the correctly returned PartialWriteError
in (*shard).validateSeriesAndFields, allow partial
writes.

closes #23090

(cherry picked from commit 0c3dca8)

closes #23096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/error handling kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly handle MaxSeriesPerDatabaseExceeded influxdata/influxdb
1 participant
@davidby-influx