feat(dashboard): isolate dashboards service (remove URM interactions) #19852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
force-pushed
the
gm/dashboards-service
branch
3 times, most recently
from
3d97fcb to
fab0549
Compare
feat(dashboard): add owner ID to dashboard model This adds the explicit OwnerID field to Dashboard and also adds a migration which populates dashboard owners IDs based on dashboard owner URMs. feat(dashboards): isolate service in own package This change isolates the dashboards service into its own package. It also updates the API to no longer interface with user resource mappings. Instead it defines new handlers which rely on the newly populated owner ID field. chore(dashboards): port tests from http package into new service transport package chore(launcher): use dashboard transport package client in launcher tests chore(kv): remove now defunkt dashboard service implementations
GeorgeMac
force-pushed
the
gm/dashboards-service
branch
from
fab0549 to
2d9dd27
Compare
4 tasks
GeorgeMac
requested review from
a team and
gavincabbage
and removed request for
a team
gavincabbage
approved these changes
Nov 2, 2020
GeorgeMac
added a commit
that referenced
this pull request
Nov 4, 2020
feat(dashboard): add owner ID to dashboard model This adds the explicit OwnerID field to Dashboard and also adds a migration which populates dashboard owners IDs based on dashboard owner URMs. feat(dashboards): isolate service in own package This change isolates the dashboards service into its own package. It also updates the API to no longer interface with user resource mappings. Instead it defines new handlers which rely on the newly populated owner ID field. chore(dashboards): port tests from http package into new service transport package chore(launcher): use dashboard transport package client in launcher tests chore(kv): remove now defunkt dashboard service implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19801
This PR does the following:
OwnerIDparameter to the Dashboards model.dashboards.TODO