refactor(telegraf): isolate telegraf config service and remove URM interactions #19819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
changed the title
|
I closed this by accident. |
GeorgeMac
force-pushed
the
gm/telegraf-service
branch
2 times, most recently
from
13bc0df to
4b51c85
Compare
GeorgeMac
force-pushed
the
gm/notification-endpoints-service
branch
4 times, most recently
from
f0c3c82 to
c94f478
Compare
GeorgeMac
force-pushed
the
gm/telegraf-service
branch
from
4b51c85 to
b82e2ca
Compare
GeorgeMac
requested review from
a team and
brettbuddin
and removed request for
a team
brettbuddin
approved these changes
Oct 29, 2020
6 tasks
GeorgeMac
force-pushed
the
gm/telegraf-service
branch
from
315b23d to
24c6526
Compare
4 tasks
brettbuddin
approved these changes
Nov 2, 2020
feat(dashboard): add owner ID to dashboard model This adds the explicit OwnerID field to Dashboard and also adds a migration which populates dashboard owners IDs based on dashboard owner URMs. feat(dashboards): isolate service in own package This change isolates the dashboards service into its own package. It also updates the API to no longer interface with user resource mappings. Instead it defines new handlers which rely on the newly populated owner ID field. chore(dashboards): port tests from http package into new service transport package chore(launcher): use dashboard transport package client in launcher tests chore(kv): remove now defunkt dashboard service implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19800
The purpose of this change is to sever the dependency on the URM service from the
TelegrafConfigService.It does need it to function (much like endpoints and rules it misused this service).
This change introduces a new isolated Telegraf package implementation of the service and it removes the behaviors from the
*kv.Serviceimplementation.Further, supporting the work to remove behaviors from the
*kv.Service: #19783UPDATE:
I noticed that I had left a todo to add support for pagination parameters. So I added limit and offset support to find telegrafs.
While doing so, I found it was favorable to update the
kv.VisitFuncabstraction to return both an error and now a keep walkingbool. So now you returnfalsewhen you want to stop cursing. This touched a few things, but I believe I got them all. Some places were returning a sentinel error to stay stop walking. I fixed those place to just produce afalse(stop walking) response instead.I deleted both
kvandhttptelegraf config service implementations. Moving us solely totelegrafpackage imple mentation.