Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for success/failed when creating/deleting/updating … #12023

Merged
merged 1 commit into from
Feb 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

### UI Improvements
1. [12016](https://github.com/influxdata/influxdb/pull/12016): Update the preview in the label overlays to be shorter
1. [12012](https://github.com/influxdata/influxdb/pull/12012): Add notifications to scrapers page for created/deleted/failed scrapers
1. [12012](https://github.com/influxdata/influxdb/pull/12012): Add notifications to scrapers page for created/deleted/updated scrapers
1. [12023](https://github.com/influxdata/influxdb/pull/12023): Add notifications to buckets page for created/deleted/updated buckets

## v2.0.0-alpha.3 [2019-02-15]

Expand Down
44 changes: 35 additions & 9 deletions ui/src/organizations/components/Buckets.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,14 @@ interface State {

// Decorators
import {ErrorHandling} from 'src/shared/decorators/errors'
import {bucketDeleted} from 'src/shared/copy/v2/notifications'
import {
bucketDeleteSuccess,
bucketDeleteFailed,
bucketCreateFailed,
bucketCreateSuccess,
bucketUpdateFailed,
bucketUpdateSuccess,
} from 'src/shared/copy/v2/notifications'

@ErrorHandling
export default class Buckets extends PureComponent<Props, State> {
Expand Down Expand Up @@ -106,21 +113,40 @@ export default class Buckets extends PureComponent<Props, State> {
}

private handleUpdateBucket = async (updatedBucket: PrettyBucket) => {
await client.buckets.update(updatedBucket.id, updatedBucket)
this.props.onChange()
const {onChange, notify} = this.props
try {
Palakp41 marked this conversation as resolved.
Show resolved Hide resolved
await client.buckets.update(updatedBucket.id, updatedBucket)
onChange()
notify(bucketUpdateSuccess(updatedBucket.name))
} catch (e) {
console.error(e)
notify(bucketUpdateFailed(updatedBucket.name))
}
}

private handleDeleteBucket = async (deletedBucket: PrettyBucket) => {
const {onChange, notify} = this.props
await client.buckets.delete(deletedBucket.id)
onChange()
notify(bucketDeleted(deletedBucket.name))
try {
await client.buckets.delete(deletedBucket.id)
onChange()
notify(bucketDeleteSuccess(deletedBucket.name))
} catch (e) {
console.error(e)
bucketDeleteFailed(deletedBucket.name)
}
}

private handleCreateBucket = async (bucket: Bucket): Promise<void> => {
await client.buckets.create(bucket)
this.props.onChange()
this.handleCloseModal()
const {onChange, notify} = this.props
try {
await client.buckets.create(bucket)
onChange()
this.handleCloseModal()
notify(bucketCreateSuccess())
} catch (e) {
console.error(e)
notify(bucketCreateFailed())
}
}

private handleOpenModal = (): void => {
Expand Down
29 changes: 27 additions & 2 deletions ui/src/shared/copy/v2/notifications.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,34 @@ export const labelUpdateFailed = (): Notification => ({
message: 'Failed to update label',
})

export const bucketDeleted = (bucketName: string): Notification => ({
export const bucketDeleteSuccess = (bucketName: string): Notification => ({
...defaultSuccessNotification,
message: `Bucket ${bucketName} was successfully deleted`,
message: `Bucket "${bucketName}" was successfully deleted`,
})

export const bucketDeleteFailed = (bucketName: string): Notification => ({
...defaultErrorNotification,
message: `Failed to delete bucket: "${bucketName}"`,
})

export const bucketCreateSuccess = (): Notification => ({
...defaultSuccessNotification,
message: 'Bucket was successfully created',
})

export const bucketCreateFailed = (): Notification => ({
...defaultErrorNotification,
message: 'Failed to create bucket',
})

export const bucketUpdateSuccess = (bucketName: string): Notification => ({
...defaultSuccessNotification,
message: `Bucket "${bucketName}" was successfully updated`,
})

export const bucketUpdateFailed = (bucketName: string): Notification => ({
...defaultErrorNotification,
message: `Failed to update bucket: "${bucketName}"`,
})

export const scraperDeleteSuccess = (scraperName: string): Notification => ({
Expand Down