Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for success/failed when creating/deleting/updating … #12023

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 20, 2019

…buckets

Closes #11906

Briefly describe your proposed changes:
Created notifications for buckets for success/failed for creating/updating/deleting buckets

  • Rebased/mergeable
  • Tests pass

kapture 2019-02-20 at 15 15 54

@Palakp41 Palakp41 force-pushed the feat/bucket-notifications branch from b459ede to 6981523 Compare February 20, 2019 23:19
Copy link
Contributor

@ischolten ischolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

ui/src/organizations/components/Buckets.tsx Show resolved Hide resolved
@Palakp41 Palakp41 merged commit 09d0847 into master Feb 21, 2019
@Palakp41 Palakp41 deleted the feat/bucket-notifications branch February 21, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants