Ensure value is a String before calling toLowerCase() on it (Fixes #113) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issotina
added a commit
to CloudCommunik/jambonz-feature-server
that referenced
this pull request
May 2, 2022
Currently this project is affected by one of node 18 (latest version) breaking change which impact node-ip dependence: indutny/node-ip#114 nodejs/node#42787
|
@indutny, could you take a look? |
antongolub
added a commit
to qiwi/mware
that referenced
this pull request
May 3, 2022
antongolub
added a commit
to qiwi/mware
that referenced
this pull request
May 3, 2022
antongolub
added a commit
to qiwi/mware
that referenced
this pull request
May 3, 2022
|
Oh gosh, sorry I missed this PR! It does exactly the same thing as what I committed myself so I feel terrible for not finding your work until now. That being said the issue is fixed and a new version was released. |
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover from the Node 18 introduced
Undocumented change to "family" attribute in os.networkInterfaces() in Node 18