New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with node 18.0.0 and ip package #1332

Merged

pavjacko merged 1 commit into release/1.0 from fix/bump_ip

Jan 4, 2024

Contributor

mihaiblaga89 commented Jan 3, 2024

Description

Apparently node 18.0.0 can cause issues for "ip" package. Ensure value is a String before calling toLowerCase() on it (Fixes #113) indutny/node-ip#114. @Marius456 encountered this issue. As a bonus latest version fixes this as well Buffer() is deprecated due to security and usability issues indutny/node-ip#109

Screenshot 2024-01-03 at 17 44 52

Related issues

none

Npm releases

n/a


          update ip to 1.1.8

70b4442

pavjacko approved these changes

View reviewed changes

pavjacko merged commit 3af4669 into release/1.0

1 check passed

pavjacko deleted the fix/bump_ip branch

January 4, 2024 08:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet