Document breaking change in Change Log. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zegnat
force-pushed
the
zegnat/add-grant_type-to-changelog
branch
from
2c1a63b to
d1c008d
Compare
Zegnat
force-pushed
the
zegnat/add-grant_type-to-changelog
branch
from
d1c008d to
15b11ce
Compare
|
Apologies for the force pushes. Apparently I am unable to read 🤦♀️ |
|
I don't think changing the list IDs matters |
aaronpk
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sections for redeeming the authorization code at the authorization endpoint and token endpoint were merged together, we defaulted to letting both use the same request. This is a breaking change. Previous to the August 9 update, there was no need to specify
grant_typewhen redeeming at the authorization endpoint.This ads it to the change log: on the current spec, in the current draft, and in the previous snapshots that should have listed it.
I put it as the second item in the change log, because I thought it read better that way. This does mean all the list IDs get shifted. Does this really matter for individual change log items? If we think it does, we will have to move it to the end of the list instead.
Fixes #61.