Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changelog that grant_type is now required #61

Closed
dshanske opened this issue Oct 3, 2020 · 3 comments · Fixed by #69
Closed

Document changelog that grant_type is now required #61

dshanske opened this issue Oct 3, 2020 · 3 comments · Fixed by #69

Comments

@dshanske
Copy link
Member

dshanske commented Oct 3, 2020

In the current living standard, grant_type is required by the authorization endpoint. In the prior version, it was not. This change needs to be documented due the fact it could be a breaking change.

@Zegnat
Copy link
Member

Zegnat commented Nov 21, 2020

I think this is wrong?

Maybe I am missing something, but I think grant_type has always been required. It was response_type that was optional (in the case of response_type=id) and that has been documented as part of the August 9th changes.

Am I misreading something?

@dshanske
Copy link
Member Author

@Zegnat For the token endpoint, but not the authorization endpoint.

@Zegnat
Copy link
Member

Zegnat commented Nov 22, 2020

Ah, found it now @dshanske. Thanks! PR opened with fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants