Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles should not assume the rvt-sticker will be defined #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

basham
Copy link
Member

@basham basham commented Jul 11, 2024

The CSS selector rvt-sticker:not(:defined)::before assumes that the Rivet Sticker Element will be defined. However, there may be a case in which the user wants to use a sticker but have it statically rendered by manually copying the sticker SVG code (due to server-side rendering or restrictive front-end environments).

<rvt-sticker>
  <svg>
</rvt-sticker>

Instead, by updating that selector to rvt-sticker:empty::before, it means that the initial loading style (empty circle background in a pseudo element) will only be applied if the element is empty (such as waiting for the custom element to be defined) — not when there is something there (such as when SVG is manually included or when the custom element is attached to the DOM).

Copy link
Member

@levimcg levimcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants