Styles should not assume the rvt-sticker will be defined #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS selector
rvt-sticker:not(:defined)::before
assumes that the Rivet Sticker Element will be defined. However, there may be a case in which the user wants to use a sticker but have it statically rendered by manually copying the sticker SVG code (due to server-side rendering or restrictive front-end environments).Instead, by updating that selector to
rvt-sticker:empty::before
, it means that the initial loading style (empty circle background in a pseudo element) will only be applied if the element is empty (such as waiting for the custom element to be defined) — not when there is something there (such as when SVG is manually included or when the custom element is attached to the DOM).