Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles should not assume the rvt-icon will be defined #108

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

basham
Copy link
Member

@basham basham commented Jul 11, 2024

The CSS selector rvt-icon:not(:defined)::before assumes that the Rivet Icon Element will be defined. However, there may be a case in which the user wants to use an icon but have it statically rendered by manually copying the icon SVG code (due to server-side rendering or restrictive front-end environments).

<rvt-icon>
  <svg>
</rvt-icon>

Instead, by updating that selector to rvt-icon:empty::before, it means that the initial loading style (16px square pseudo element) will only be applied if the element is empty (such as waiting for the custom element to be defined) — not when there is something there (such as when SVG is manually included or when the custom element is attached to the DOM).

This PR solves the same issue found in indiana-university/rivet-stickers#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants