Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for Darwin/Mac #17

Merged
merged 14 commits into from
Nov 26, 2018
Merged

Better support for Darwin/Mac #17

merged 14 commits into from
Nov 26, 2018

Conversation

huan
Copy link
Contributor

@huan huan commented Jun 1, 2016 •
edited
Loading

see #18

@huan
Copy link
Contributor Author

huan commented Aug 26, 2016

could we accept this? then I could pull new pr for 'COMM' & 'COMMAND'

@huan huan mentioned this pull request Sep 5, 2016
Closed
@johanneswuerbach
Copy link

Any help needed @indexzero / @zixia ? I would also like to see this merged.

@soyuka
Copy link

soyuka commented Apr 30, 2017

nice work, would be great if it'd get merged! @indexzero any way you could add some ppl as collaborators? Thanks!

@simonepri
Copy link
Collaborator

simonepri commented Mar 16, 2018 •
edited
Loading

@zixia we can close this in favour of #29?

@simonepri simonepri mentioned this pull request Mar 16, 2018
Open
@huan huan changed the title Win32 CI - Appveyor Support Better support for Darwin/Mac Mar 16, 2018
@simonepri
Copy link
Collaborator

simonepri commented Mar 16, 2018 •
edited
Loading

@zixia Can you add a section inside the readme under Cross Platform support for darwin?
Something like:

Darwin

  1. " " need to be striped
$ ps -A -o comm,ppid,pid,stat
COMM              PPID   PID STAT
/sbin/launchd        0     1 Ss
/usr/libexec/Use     1    43 Ss

@huan
Copy link
Contributor Author

huan commented Mar 16, 2018

@simonepri done.

@simonepri
Copy link
Collaborator

simonepri commented Mar 16, 2018 •
edited
Loading

LGTM!
But lets merge #27 before this.

@simonepri simonepri mentioned this pull request Mar 18, 2018
Merged
@indexzero indexzero merged commit 2b6476c into indexzero:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonepri simonepri simonepri approved these changes

@soyuka soyuka soyuka approved these changes

@indexzero indexzero indexzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huan @johanneswuerbach @soyuka @simonepri @indexzero