Add a unittest for syncing to label revision specifier #173
Conversation
| @@ -110,7 +110,7 @@ def test_fixture(capsys, server): | |||
| } | |||
|
|
|||
| # Check submitted changes | |||
| submitted_changes = [change for change in repo.perforce.run_changes('-s', 'submitted')] | |||
| submitted_changes = repo.perforce.run_changes('-s', 'submitted') | |||
There was a problem hiding this comment.
I haven't understood why to remove the iteration over the array so far...?
There was a problem hiding this comment.
Oh - the unnecessary list comprehensions driveby, I suppose?
| labelinfo = { | ||
| label.get('label'): {key: label.get(key) | ||
| for key in ['Revision'] | ||
| } | ||
| for label in labels | ||
| } |
There was a problem hiding this comment.
I'm not hissy enough to unpack what's going on here beyond what it says in the comment :(
There was a problem hiding this comment.
It's a bit confusing that p4 api choses label as the key for what might better be described as a name or identifier - if you imagine label.get('label') was instead label.get('name') it might be more readable..
The result of run_labels() looks like:
labels = [{'label': 'my-label', 'Revision': '@2', 'AnotherKey': 'blah'}, ... more labels]
Then the 'filter' is a dict comprehension, for example:
squared_numbers = {num: num*num for num in range(1, 4)}
^key^ ^value^
# squared_numbers = {1: 1, 2: 4, 3: 9}
In this case we nest one comprehension inside another: one to get each label which then maps to the result of a second comprehension which gets each interesting field (in this case, just 'Revision') for that label
Then labelinfo below is the result of the comprehension
Hope that helps clarify 😄
There was a problem hiding this comment.
It does help to clarify, but I'm still not sure I ... comprehend. ;-)
Thanks!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: improbable-mattchurch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* master: Upgrade p4python to 2020.1 (#179) ENG-3659 Disable tmp cleanup for P4Python connections (#178) Add example workspace cleanup script (#174) Revert "Force in case the client has files open (#176)" (#177) Force in case the client has files open (#176) ENG-3523 Create virtual env once for unique requirements.txt (#167)
…uildkite-plugin into label-unittest * 'label-unittest' of github.com:improbable-eng/perforce-buildkite-plugin:
* master: Add a unittest for syncing to label revision specifier (#173)
Add a unit test to validate syncing to labels works as expected
test_fixturefor how to modify the fixture, creating a label manuallymy-labelAlso driveby fix some boilerplate list comprehensions that werent necessary
Relates to #172