ENG-3659 Disable tmp cleanup for P4Python connections #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-johnson
changed the title
ca-johnson
requested review from
improbable-mattchurch,
mattyoung-improbable and
petemounce
petemounce
approved these changes
Sep 2, 2020
improbable-mattchurch
approved these changes
Sep 2, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: improbable-mattchurch, petemounce The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ca-johnson
added a commit
that referenced
this pull request
Sep 3, 2020
…-buildkite-plugin into upgrade-p4python * 'upgrade-p4python' of github.com:improbable-eng/perforce-buildkite-plugin: ENG-3659 Disable tmp cleanup for P4Python connections (#178)
ca-johnson
added a commit
that referenced
this pull request
Sep 3, 2020
* master: Upgrade p4python to 2020.1 (#179) ENG-3659 Disable tmp cleanup for P4Python connections (#178) Add example workspace cleanup script (#174) Revert "Force in case the client has files open (#176)" (#177) Force in case the client has files open (#176) ENG-3523 Create virtual env once for unique requirements.txt (#167)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed to resolve issue where we occasionally get segfaults when using many p4 connections.
From release notes
We only need to call this once in the scripts lifetime, not for each connection.