Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the Stripe connect redirect on specific pages #7223

Merged
merged 7 commits into from
Feb 8, 2024
+130 −6
Merged

Handle the Stripe connect redirect on specific pages #7223

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7dab3e3
add: handle stripe connect redirect on specific pages
ravinderk Feb 7, 2024
966a967
doc: upadet function document
ravinderk Feb 7, 2024
2193d15
fix: improve logic to detect v2 donation form edit page
ravinderk Feb 7, 2024
9ef8cba
refactor: add a function to return whether we can process request on …
ravinderk Feb 7, 2024
85f2669
change: remove duplicate check
ravinderk Feb 7, 2024
587c8cd
tests: add test to test page validation function
ravinderk Feb 7, 2024
864f1a1
add: add type to function param
ravinderk Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/PaymentGateways/Stripe/Controllers/NewStripeAccountOnBoardingController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ public function __construct(Settings $settings)
}

/**
* @unreleased Handle Stripe connect account on-boarding redirect on specific pages.
* Admin redirect to following page:
* 1. GiveWP stripe settings page.
* 2. V2 donation form edit form.
* @since 2.13.0
*/
public function __invoke()
Expand All @@ -38,6 +42,15 @@ public function __invoke()
return;
}

$isDonationFormPage = isset($_GET['give_tab']) && $_GET['give_tab'] !== 'stripe_form_account_options';
$isSettingPage = isset($_GET['tab'], $_GET['tab'])
&& Give_Admin_Settings::is_setting_page('gateways', 'stripe-settings');
ravinderk marked this conversation as resolved.
Show resolved Hide resolved

// Exit if admin is not redirect to the GiveWP settings page or donation form page.
if (! $isDonationFormPage && ! $isSettingPage) {
return;
}

ravinderk marked this conversation as resolved.
Show resolved Hide resolved
$requestedData = NewStripeAccountOnBoardingDto::fromArray(give_clean($_GET));

if (!$requestedData->hasValidateData()) {
Expand Down
Loading