Handle the Stripe connect redirect on specific pages #7223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
Feb 7, 2024
src/PaymentGateways/Stripe/Controllers/NewStripeAccountOnBoardingController.php
Outdated
Show resolved
Hide resolved
src/PaymentGateways/Stripe/Controllers/NewStripeAccountOnBoardingController.php
Outdated
Show resolved
Hide resolved
ravinderk
force-pushed
the
fix/handle-stripe-onboarding-redirect-correctly
branch
from
e303ea6 to
2193d15
Compare
is_setting_page function handle this check internally.
|
@jonwaldstein, I've implemented several improvements based on your suggestions and added tests to validate the functionality. |
jonwaldstein
approved these changes
Feb 7, 2024
jonwaldstein
deleted the
fix/handle-stripe-onboarding-redirect-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the query param, we are handling the Stripe redirect from the connect gateway server. We should limit handling to specific pages to prevent conflict.
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks