Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add state_label and states keys to give_get_states ajax function #6837

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jun 30, 2023

Related: impress-org/givewp-next-gen#204

Description

This adds state_label and states to the give_get_states() ajax function for use in the new BillingAddress block from this PR.

Affects

Technically the give_get_states() but is only adding new keys, not modifying existing functionality.

Visuals

N/A

Testing Instructions

  • state_label should return the state label based on the country
  • states should return an array of states based on the country

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review June 30, 2023 17:56
@jonwaldstein
Copy link
Contributor Author

@glaubersilva this is ready for review.

Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein Looks good to me! Do you think we need to send it to QA? As this does not change any previous values on the response, I believe would be ok just to merge it, but let me know your thoughts.

@jonwaldstein
Copy link
Contributor Author

@glaubersilva thanks, yeah I'll sent it to QA just to be safe.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@jonwaldstein jonwaldstein merged commit d5b2243 into develop Jul 6, 2023
@jonwaldstein jonwaldstein deleted the feature/ajax-states branch July 6, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants