Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: add billing address block #204

Merged
merged 57 commits into from
Jul 12, 2023
Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jun 21, 2023

Description

Depends on impress-org/givewp#6837

This PR adds a billing address block that allows users to collect the donor's address during the donation process.

Affects

Form Builder

Visuals

image

image

Testing Instructions

  1. Create a new block;
  2. Add the new billing fields block to the form;
  3. Save the form;
  4. Create a new donation using the form;
  5. Check the donations page to make sure that the billing address was saved.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva changed the title feature: add initial billing address block files Feature: add address block Jun 22, 2023
@glaubersilva glaubersilva changed the title Feature: add address block Feature: add billing address block Jun 22, 2023
@glaubersilva glaubersilva marked this pull request as ready for review June 23, 2023 22:16
@glaubersilva
Copy link
Contributor Author

@jonwaldstein I did some cosmetic changes to improve UI feedback and also change a few design details discussed in the comment of this video: https://www.loom.com/share/af7ad39687504710bb838b0b5eb3e5a7

So, it should be ready for a final review now.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaubersilva this is looking great! just a few comments/questions

@glaubersilva glaubersilva requested a review from jonwaldstein July 5, 2023 16:57
@glaubersilva glaubersilva self-assigned this Jul 7, 2023
@glaubersilva
Copy link
Contributor Author

@jonwaldstein I did the last change you request and open a new PR for the focus ring change. Let me know if there is anything more.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaubersilva great job man!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@jonwaldstein jonwaldstein merged commit 222cb7f into develop Jul 12, 2023
@kjohnson kjohnson deleted the feature/billing-address-block branch July 25, 2023 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants