-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
… like in the editor
@jonwaldstein I did some cosmetic changes to improve UI feedback and also change a few design details discussed in the comment of this video: https://www.loom.com/share/af7ad39687504710bb838b0b5eb3e5a7 So, it should be ready for a final review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva this is looking great! just a few comments/questions
src/FormBuilder/resources/js/form-builder/src/styles/_block-editor.scss
Outdated
Show resolved
Hide resolved
src/DonationForms/resources/app/utilities/BillingAddressStateSelector.tsx
Outdated
Show resolved
Hide resolved
src/FormBuilder/resources/js/form-builder/src/blocks/fields/login/icon.tsx
Show resolved
Hide resolved
@jonwaldstein I did the last change you request and open a new PR for the focus ring change. Let me know if there is anything more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva great job man!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests
Description
Depends on impress-org/givewp#6837
This PR adds a billing address block that allows users to collect the donor's address during the donation process.
Affects
Form Builder
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks