Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Design Preview can now switch templates #81

Merged
merged 5 commits into from
Nov 4, 2022

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Nov 3, 2022

Description

This PR adds a new template form setting with a corresponding <SelectControl /> which switches the template used in the <DesignPreview /> canvas.

NOTE: There are some styling issues with the <select /> element that need to be addressed.

Visuals

image

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson requested a review from jonwaldstein November 3, 2022 17:27
@kjohnson kjohnson marked this pull request as ready for review November 3, 2022 17:33
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjohnson great job man! I did a hot fix for that select padding issue. Also, I left a reply and comments on this thread you started. Approving now so those can be addressed now or later.

@kjohnson kjohnson merged commit c35ad80 into develop Nov 4, 2022
@kjohnson kjohnson deleted the feature/template-form-setting branch November 11, 2022 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants