Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Storage Driver should use the FormData interface for previews #82

Closed
kjohnson opened this issue Nov 4, 2022 · 0 comments
Closed

Storage Driver should use the FormData interface for previews #82

kjohnson opened this issue Nov 4, 2022 · 0 comments
Labels
stale

Comments

@kjohnson
Copy link
Contributor

kjohnson commented Nov 4, 2022

Details

@jonwaldstein I'm considering updating the signature of the preview method to match the FormData interface used by save and load. Also, if blocks is a property of formSettings then the interface can probably be simplified.

Originally posted by @kjohnson in #81 (comment)

Ah yeah, that would make sense to do.

Originally posted by @jonwaldstein in #81 (comment)

Also, I think it would make more sense to change template to templateId just so it's more clear that we are referring to the ID of the template specifically.

Originally posted by @jonwaldstein in #81 (comment)

image
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjohnson