-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
src/FormBuilder/resources/js/form-builder/src/styles/_block-editor.scss
Outdated
Show resolved
Hide resolved
@jonwaldstein Thanks for the explanations, now I better understand your concerns in regard to this. I did implement your suggestion with a slight difference, let me know if there is anything else. |
@glaubersilva thanks! looks good to me but i'm also not the designer. I'm thinking since this will affect all block selections we should do a quick screen share with @jdghinson to get his thoughts. I think in his earlier designs he had a selected ring but there was no padding - so we'll want to see how this interacts with different block types. |
@jonwaldstein Thanks! I already create a new zip with these last changes and send it to @jdghinson via Slack for a re-review. |
@jonwaldstein After @jdghinson reviewed it, we implemented a couple of cosmetic changes, but one specific required a bit of JS. So, I recorded a video to better explain why it was necessary, let me know your thoughts on it. Thanks! Video: https://www.loom.com/share/6031260278924155b4289a856a0417d1 |
src/FormBuilder/resources/js/form-builder/src/common/popover.js
Outdated
Show resolved
Hide resolved
@jonwaldstein This is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva great job man!
Description
This PR adds a focus ring for the blocks when they are selected. This feature is helpful because provides UI feedback about which block is selected.
Affects
The form builder
Visuals
Testing Instructions
Click on any block in the form builder and you should see a blue focus ring indicating that the block is selected, check the attached screenshot for reference.
Pre-review Checklist
@unreleased
tags included in DocBlocks