Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint 5 support #1122

Merged
merged 2 commits into from
Jun 24, 2018
Merged

Add ESLint 5 support #1122

merged 2 commits into from
Jun 24, 2018

Conversation

ai
Copy link
Contributor

@ai ai commented Jun 23, 2018

I start to use ESLint 5 on my project with your plugin and didn’t find any problem with compatibility.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add eslint 5 to the tests here: https://github.com/benmosher/eslint-plugin-import/blob/master/.travis.yml#L10

Also, please make sure the devDep for eslint matches the peerDep.

The tests for eslint 5 in node 4 will likely fail; I’ll update this PR later today to handle that.

@ljharb ljharb mentioned this pull request Jun 23, 2018
21 tasks
@ai
Copy link
Contributor Author

ai commented Jun 23, 2018

@ljharb thanks for fast reply.

I updated devDependencies, added ESLint 5 to Travis CI, and exclude “ESLint 5 + Node.js 4” from tests matrix.

@coveralls
Copy link

coveralls commented Jun 23, 2018

Coverage Status

Coverage remained the same at 97.271% when pulling 9db789b on ai:patch-1 into 59fc04e on benmosher:master.

@jaydenseric
Copy link

jaydenseric commented Jun 24, 2018

@ljharb
Copy link
Member

ljharb commented Jun 24, 2018

We don't have to get rid of that just yet; deprecation warnings can be ignored. In the test, we can set the ecmaVersion to 2018.

@ai
Copy link
Contributor Author

ai commented Jun 24, 2018

I updated ecmaVersion and removed experimentalObjectRestSpread in these two places

@ljharb ljharb self-assigned this Jun 24, 2018
@ljharb ljharb merged commit 9db789b into import-js:master Jun 24, 2018
@ljharb
Copy link
Member

ljharb commented Jun 24, 2018

Released in v2.13.0

(linking back to airbnb/javascript#1834)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants