-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint 5 support #1122
Add ESLint 5 support #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add eslint 5 to the tests here: https://github.com/benmosher/eslint-plugin-import/blob/master/.travis.yml#L10
Also, please make sure the devDep for eslint matches the peerDep.
The tests for eslint 5 in node 4 will likely fail; I’ll update this PR later today to handle that.
@ljharb thanks for fast reply. I updated |
Need to get rid of the deprecated |
We don't have to get rid of that just yet; deprecation warnings can be ignored. In the test, we can set the ecmaVersion to 2018. |
I updated |
Released in v2.13.0 (linking back to airbnb/javascript#1834) |
I start to use ESLint 5 on my project with your plugin and didn’t find any problem with compatibility.