Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint v5 support #1834

Closed
21 tasks done
ljharb opened this issue Jun 21, 2018 · 14 comments
Closed
21 tasks done

eslint v5 support #1834

ljharb opened this issue Jun 21, 2018 · 14 comments
Assignees

Comments

@ljharb
Copy link
Collaborator

ljharb commented Jun 21, 2018

Just like #1447, I'm filing this in advance.

v17.0.0 of eslint-config-airbnb and v13.0.0 of eslint-config-airbnb-base have just been released.

eslint v5 is planned to be released in the next 24-48 hours, and the plan for our configs will be to either support v3 || v4 || v5, or, if necessary, to drop support for v3 and/or v4 as part of this release.

The timeframe is "probably not as soon as you would like, but as soon as we can".
Please accept this, and please add no noise to this thread beyond emoji reactions - distractions won't help anyone get the work done any faster.

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v4 until such time as our configs support v5.

Peer Dep eslint combined v3 and v4 and v5 support released, or v5 support released (depending on which path we need to take):

@ljharb ljharb self-assigned this Jun 21, 2018
amercier added a commit to amercier/npm-package-skeleton that referenced this issue Jun 28, 2018
kevinoid added a commit to kevinoid/node-project-template that referenced this issue Jun 29, 2018
@YasharF
Copy link

YasharF commented Jul 6, 2018

Thank you for the great work. It looks like the remaining tasks on the list are the publishing tasks. Do you have any estimates on when to expect the new version to be published?

@ljharb
Copy link
Collaborator Author

ljharb commented Jul 6, 2018

I'm waiting on a few bugs (that i've just added).

@bjankord
Copy link

Hey @ljharb, curious what that status is on this. I saw some bugfixes landed in jsx-a11y-plugin.

@danactive
Copy link

I would love to read why "react/jsx-one-expression-per-line" is enabled. Is there a trend for developers to rotate their monitors vertically after this change 😆

This changes one readable line

<App>Hello World</App>

to an uncomfortable syntax

<App>
  { 'Hello' }
  { ' ' }
  { 'World' }
</App>

@ryansully
Copy link

@danactive That rule was turned off in b6a268f.
Hopefully the next release that includes the commit above will be out soon.

Your concern was also brought up here and here.

@tunnckoCore

This comment has been minimized.

@stepankuzmin

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb
Copy link
Collaborator Author

ljharb commented Aug 13, 2018

eslint-config-airbnb v17.1.0 and eslint-config-airbnb-base v13.1.0 have been released, with eslint 5 support.

@ljharb ljharb closed this as completed Aug 13, 2018
@tunnckoCore
Copy link

Yeah!

@kmaitski
Copy link

kmaitski commented Aug 17, 2018

Is anyone still having the same issue after upgrading?

Here are my devDependencies, but I am still running into the same issue.

`
"eslint": "^5.3.0",

    "eslint-config-airbnb": "^17.1.0",

    "eslint-config-airbnb-base": "^13.1.0",

    "eslint-loader": "^2.1.0",

    "eslint-plugin-import": "^2.14.0",

    "eslint-plugin-jsx-a11y": "^6.1.1",

    "eslint-plugin-react": "^7.10.0",

`

Am I doing something wrong?

@ljharb
Copy link
Collaborator Author

ljharb commented Aug 17, 2018

@kmaitski what does npm ls say? Have you tried running the peer deps install command in the readme for eslint-config-airbnb?

Either way, please file a new issue if you're still having trouble.

@ljharb

This comment has been minimized.

@noahbenham

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants