Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): keyboard event propagation in modals #9713

Merged
merged 5 commits into from
May 26, 2024
Merged

fix(web): keyboard event propagation in modals #9713

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0249463
fix: key events propagating from modal, visible close button focus
ben-basten May 23, 2024
121ec33
Merge branch 'main' of https://github.com/immich-app/immich into fix/…
ben-basten May 23, 2024
92a3ac7
feat: set initial focus on the text field for album creation
ben-basten May 23, 2024
6ddbe81
Merge branch 'main' of https://github.com/immich-app/immich into fix/…
ben-basten May 24, 2024
f78a134
chore: step back duplicated changes
ben-basten May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions web/src/lib/components/shared-components/full-screen-modal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,16 @@
}
</script>

<FocusTrap>
<section
role="presentation"
in:fade={{ duration: 100 }}
out:fade={{ duration: 100 }}
class="fixed left-0 top-0 z-[9990] flex h-screen w-screen place-content-center place-items-center bg-black/40"
>
<section
role="presentation"
in:fade={{ duration: 100 }}
out:fade={{ duration: 100 }}
class="fixed left-0 top-0 z-[9990] flex h-screen w-screen place-content-center place-items-center bg-black/40"
on:keydown={(event) => {
event.stopPropagation();
}}
>
<FocusTrap>
<div
class="z-[9999] max-w-[95vw] max-h-[95vh] {modalWidth} overflow-y-auto rounded-3xl bg-immich-bg shadow-md dark:bg-immich-dark-gray dark:text-immich-dark-fg immich-scrollbar"
style="max-height: min(95vh, 900px);"
Expand All @@ -72,5 +75,5 @@
</div>
{/if}
</div>
</section>
</FocusTrap>
</FocusTrap>
</section>
Loading