Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): keyboard event propagation in modals #9713

Merged
merged 5 commits into from
May 26, 2024

Conversation

ben-basten
Copy link
Member

@ben-basten ben-basten commented May 24, 2024

Description

Fixes #8805

Follow up to #9701 where the album selection modal automatically focuses the text field.

In this change:

  • Prevent keyboard events from propagating outside of the modal, since the modal as the active element on the page that the user is interacting with.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

@ben-basten ben-basten changed the title fix: album selection modal keyboard input fix(web): album selection modal keyboard input May 24, 2024
@ben-basten ben-basten marked this pull request as ready for review May 24, 2024 15:31
@ben-basten ben-basten changed the title fix(web): album selection modal keyboard input fix(web): keyboard event propagation in modals May 24, 2024
@alextran1502 alextran1502 merged commit 9628ea2 into immich-app:main May 26, 2024
28 of 34 checks passed
@ben-basten ben-basten deleted the fix/8805 branch May 26, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Search bar doesn't autofocus when adding photos to album.
3 participants