feat(web): add types to dispatcher #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martabal
force-pushed
the
feat/types-dispatcher
branch
from
001c5e4 to
1753089
Compare
Deploying with
|
| Latest commit: |
108bdb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de584add.immich.pages.dev |
| Branch Preview URL: | https://feat-types-dispatcher.immich.pages.dev |
jrasm91
reviewed
Dec 14, 2023
web/src/lib/components/admin-page/delete-confirm-dialoge.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/shared-components/control-app-bar.svelte
Outdated
Show resolved
Hide resolved
jrasm91
reviewed
Dec 14, 2023
web/src/lib/components/user-settings-page/user-api-key-list.svelte
Outdated
Show resolved
Hide resolved
alextran1502
approved these changes
Dec 15, 2023
alextran1502
changed the title
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* feat: add types to dispatcher * fix: create album name * pr feedback * pr feedback * pr feedback * fix: api key name * remove newSharedAlbum * pr feedback * fix: api key creation * on:close * fix: owner * fix: onclose * remove unused code --------- Co-authored-by: Alex Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
Continuing work on #5698, this PR adds types to every
createEventDispatcher