fix(web): user management responsive design #5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
14f61dc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acc40f88.immich.pages.dev |
| Branch Preview URL: | https://fix-user-management-tailwind.immich.pages.dev |
jrasm91
approved these changes
Dec 14, 2023
| > | ||
| <div class="absolute inset-y-0 right-0 px-2 py-2 h-fit"> | ||
| <CircleIconButton icon={mdiClose} on:click={() => dispatch('close')} /> |
There was a problem hiding this comment.
While you are here, do you mind adding types for the dispatcher? In general they are missing in many places and I think it would be easy enough to add whenever we update a file that is missing them.
jrasm91
approved these changes
Dec 14, 2023
alextran1502
changed the title
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* fix: user management tailwind * use top instead of inset-y-0 * add types to createEventDispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
Improve the user management responsive design and add a close button on the edit user modal.
Screenshots
2023-12-14.15-47-52.mp4
2023-12-14.15-46-56.mp4