-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require proxies for a correct working #22
Conversation
immer-es5.js
Outdated
@@ -0,0 +1,244 @@ | |||
import {isObject} from "util" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where isObject is used. Is this a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. auto import :(
Great! 👏 |
@benbraou sorry, forgot to mark it as WIP! Still making some improvements besides the build :) |
Fixes #8
First implementation is promising and feature complete! Needs some clean up, feature detection etc. Performance is quite neat so far (but bare in mind that the Proxy impl is not yet optimized, while the non-proxy impl is)
The update-10k-todos-in-a-set-of-100K benchmark: