-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create es5 compatible version #8
Comments
I was thinking what about a compiler-wise option? something like a babel (or TS) plugin transformer that looks for immer() calls, and add calls to a function to report which parts of draftState may have changed, and then just compare them instead of the whole state |
I think this problem is relatively easily solvable . Gonna try tonight
…On di 2 jan. 2018 15:18 Mattia Manzati ***@***.***> wrote:
I was thinking about a compiler-wise option, something like a babel (or
TS) plugin transformer that looks for immer() calls, and add calls to a
function to report which parts of draftState may have changed, and then
just compare them instead of the whole state
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhCpCG8vdFu8axMn08HF3_bLIJRrOks5tGjqpgaJpZM4RPjVr>
.
|
Yes, it is solvable :) Implementation is basically ready but needs merging into the original impl (with code reuse, now just copy pasted the base file), see #22 |
Released! As 0.2.0. Faux arrays weren't needed, so object / array semantics remain true :) |
If there is enough interest.
Proxy using defineProperty (the mobx way), use faux arrays and dirty check for key additions
The text was updated successfully, but these errors were encountered: