Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create es5 compatible version #8

Closed
mweststrate opened this issue Dec 30, 2017 · 4 comments
Closed

Create es5 compatible version #8

mweststrate opened this issue Dec 30, 2017 · 4 comments
Assignees
Milestone

Comments

@mweststrate
Copy link
Collaborator

If there is enough interest.

Proxy using defineProperty (the mobx way), use faux arrays and dirty check for key additions

@mweststrate mweststrate self-assigned this Jan 2, 2018
@mattiamanzati
Copy link

mattiamanzati commented Jan 2, 2018

I was thinking what about a compiler-wise option? something like a babel (or TS) plugin transformer that looks for immer() calls, and add calls to a function to report which parts of draftState may have changed, and then just compare them instead of the whole state

@mweststrate
Copy link
Collaborator Author

mweststrate commented Jan 2, 2018 via email

@mweststrate
Copy link
Collaborator Author

Yes, it is solvable :) Implementation is basically ready but needs merging into the original impl (with code reuse, now just copy pasted the base file), see #22

@mweststrate
Copy link
Collaborator Author

Released! As 0.2.0. Faux arrays weren't needed, so object / array semantics remain true :)

@mweststrate mweststrate added this to the 1.0 milestone Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants